← Back to team overview

mahara-contributors team mailing list archive

[Bug 1248318] A change has been merged

 

Reviewed:  https://reviews.mahara.org/2687
Committed: http://gitorious.org/mahara/mahara/commit/c1be6b9d71fc8cadf5563efd81b48798926ff266
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit c1be6b9d71fc8cadf5563efd81b48798926ff266
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Nov 6 10:02:39 2013 +1300

Allowing for SESSION messages to have render position (bug #1248318)

- the add_ok_msg, add_error_msg, and add_info_msg functions now take a
'placement' parameter. When set it will only display the message at that
location. Defaults to 'messages', the current place they are displayed.
eg:
$SESSION->add_ok_msg('hello world!', false, 'loginbox');

- to get the message to display at new location one needs to add to
the relevant template
{dynamic}{insert_messages placement=[placement]}{/dynamic}
where [placement] = the placement parameter you are after
eg:
{dynamic}{insert_messages placement='loginbox'}{/dynamic}

Change-Id: I202d7e3e8d86ca1c74c4488f30e6c25686ac32e0
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1248318

Title:
  session messages to display in alternative places

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Wanting certain messages that get added to $_SESSION['messages'] to
  display in places other than the <div id="messages"></div> place at
  top of page.

  To handle this I am thinking that a 'placement' variable needs to be
  added to message items. This way one could easily specify the place on
  the screen where the message is to appear.

  So that the code to add a message to an alternative place, for example
  under the login auth box, would be:

    $SESSION->add_ok_msg($mymessage, false, 'loginbox');

  and in the login.tpl template have

    {dynamic}{insert_messages placement='loginbox'}{/dynamic}

  
  for all the session messages with out placement specification - they would get displayed in the default place.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1248318/+subscriptions


References