← Back to team overview

mahara-contributors team mailing list archive

[Bug 1248318] A change has been merged

 

Reviewed:  https://reviews.mahara.org/2691
Committed: http://gitorious.org/mahara/mahara/commit/8425cfea9c97ad80316f84c0fffd67aa04252fa1
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 8425cfea9c97ad80316f84c0fffd67aa04252fa1
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Nov 8 10:17:13 2013 +1300

Render_messages placement option breaks install

Bug #1248318

This fixes a regression caused by https://reviews.mahara.org/#/c/2687

Change-Id: I0ca13766336db11c9358995fa0d0f1b9d1950da1
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1248318

Title:
  Allow $SESSION messages to be displayed in alternative places

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  Wanting certain messages that get added to $_SESSION['messages'] to
  display in places other than the <div id="messages"></div> place at
  top of page.

  To handle this I am thinking that a 'placement' variable needs to be
  added to message items. This way one could easily specify the place on
  the screen where the message is to appear.

  So that the code to add a message to an alternative place, for example
  under the login auth box, would be:

    $SESSION->add_ok_msg($mymessage, false, 'loginbox');

  and in the login.tpl template have

    {dynamic}{insert_messages placement='loginbox'}{/dynamic}

  
  for all the session messages with out placement specification - they would get displayed in the default place.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1248318/+subscriptions


References