mahara-contributors team mailing list archive

[Mahara Bot <1250235@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2696
Committed: http://gitorious.org/mahara/mahara/commit/61538092deb07240218de5c72a5833b5dd08d023
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 61538092deb07240218de5c72a5833b5dd08d023
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Nov 12 11:28:35 2013 +1300

Doing better check on whether a skin is being used (bug #1250235)

was checkoing on $viewskin var rather than the $skin var set if allowed to
have skin on page

Change-Id: I6199f80f849dce1970b67f77f7638345bdb4679e
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1250235

Title:
  View gives error if user could make skins then had option revoked

Status in Mahara ePortfolio:
  In Progress

Bug description:
  When viewing the page see errors like this
  [WAR] 60 (view/view.php:321) Undefined variable: skindata
  Call stack (most recent first):

      log_message("Undefined variable: skindata", 8, true, true, "/home/robertl/htdocs/mahara-devel/mahara/htdocs/vi...", 321) at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/errors.php:430
      error(8, "Undefined variable: skindata", "/home/robertl/htdocs/mahara-devel/mahara/htdocs/vi...", 321, array(size 90)) at /home/robertl/htdocs/mahara-devel/mahara/htdocs/view/view.php:321

  The check is checking on the wrong variable

  will make a patch to fix

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1250235/+subscriptions