mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

This problem still exists.

I do note that in mahara we have:

function execute_sql_arr($sqlarr, $continue=true, $feedback=true) {

but in moodle they have:

protected function execute_sql_arr(array $sqlarr) {


So it might be worth changing our function to be more like the moodle one (have $sqlarr as the only variable) 
making this change should only affect these files (unless a third party plugin uses this function).

./htdocs/lib/dml.php
./htdocs/lib/ddl.php

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/837437

Title:
  In lib/dml.php execute_sql_arr, $continue parameter can't ever work

Status in Mahara ePortfolio:
  Triaged

Bug description:
  execute_sql_arr() calls execute_sql() to perform the actual sql query.
  It should continue if execute_sql() returns a boolean false. However,
  this can never actually happen as a execute_sql() throws an exception
  if the sql query fails. As far as I can tell the $continue parameter
  effectively does nothing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/837437/+subscriptions