mahara-contributors team mailing list archive

[Mahara Bot <1249123@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2701
Committed: http://gitorious.org/mahara/mahara/commit/666df54987d91ea3522a8d7e9df36aff73950929
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 666df54987d91ea3522a8d7e9df36aff73950929
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Tue Nov 12 16:45:16 2013 +1300

Revert "Enable 'No institution' users to use skins (Bug 1249123) if it
is activated in config.php"

This reverts commit 35a6a62ad98d9ff830291eb14815e8b0704b09c6.

Change-Id: I5902b77157fdb8df7c73dba27921c832c69b338b

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1249123

Title:
  Users who are in "No Institution" can't use skins

Status in Mahara ePortfolio:
  In Progress

Bug description:
  To replicate:

  1. Set $cfg->skins = true;
  2. Go to the configuration screen for the default institution ("No Institution")
  3. Note that unlike other institutions, there is no skins checkbox displayed
  4. Click "Submit" on the configuration screen
  5. Log in as a user in the default institution
  6. Navigate to their Portfolio section

  Expected result: They should have a "Portfolio -> Skins" option.
  Actual result: They do not.

  The problem is that, although we set institution.skins to 1 by default
  during installation and upgrade, the absence of the skins checkbox on
  the default institution's config screen means that it gets set to 0
  the first time you save anything on that screen.

  Looking at the code, I realize that the reason the skins checkbox is
  hidden form the default institution was not on purpose, but because
  the checkbox made the most logical sense placed adjacent to the other
  theming-related settings, and those all happen to be settings that
  can't be overridden for the default institution.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1249123/+subscriptions