← Back to team overview

mahara-contributors team mailing list archive

[Bug 625182] Re: lastlastlogin not set correctly in auth/saml/lib.php

 

In auth/user.php the authenticate() function sets the lastlastlogin to the value of lastlogin also, which is committed to db. 
Is the user who logs in via saml also somehow using the authenticate() function in their travels within Mahara? 

If they were it could explain how both lastlogin and lastlastlogin could
end up the same value.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/625182

Title:
  lastlastlogin not set correctly in auth/saml/lib.php

Status in Mahara ePortfolio:
  Triaged

Bug description:
  Dear all,

  Hi,

  I run Mahara 1.2.5 on our Linux server with a MySQL DB and we use Shibboleth authentication.
  I believe there is a bug in the library 
     auth/saml/lib.php

  because the lastlogin and lastlastlogin entries in the usr table of the DB were always the same for all users. This only occured with SSO. 
  I think there was an update done twice and the lastlastlogin was simply overwritten. 
  Commenting the lines 224-225 in the file  auth/saml/lib.php solved the issue for me.

             //$user->lastlastlogin = $user->lastlogin;
              //$user->lastlogin = time()
  Apparently, the update is already done somwhere else (auth/lib.php ?).
  Hope that helps.

  best regards 
    Juergen Zimmer

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/625182/+subscriptions


References