mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

The patch https://reviews.mahara.org/#/c/2082/ for bug #703980 will have
fixed this problem.

The $change for the if ($change) { } was only being set in some
situations. I made it so a default $change = false; was set up to
account for the times it wasn't been set by child if/else


** Changed in: mahara
       Status: Incomplete => Invalid

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1051495

Title:
  Warning when deleting default journal

Status in Mahara ePortfolio:
  Invalid

Bug description:
  Mahara 1.6dev latest code

  I have 2 journals with 1 entry each and wanted to delete the default
  journal. It is being deleted, but the following warning message is
  displayed:

  ----------------

  [WAR] 6c (blocktype/lib.php:1114) Undefined variable: change
  Call stack (most recent first):

      log_message("Undefined variable: change", 8, true, true, "/home/kristina/code/16stable/htdocs/blocktype/lib....", 1114) at /home/kristina/code/16stable/htdocs/lib/errors.php:446
      error(8, "Undefined variable: change", "/home/kristina/code/16stable/htdocs/blocktype/lib....", 1114, array(size 5)) at /home/kristina/code/16stable/htdocs/blocktype/lib.php:1114
      BlockInstance::bulk_delete_artefacts(array(size 3)) at /home/kristina/code/16stable/htdocs/artefact/lib.php:633
      ArtefactType::_delete_dbrecords(array(size 1)) at /home/kristina/code/16stable/htdocs/artefact/lib.php:504
      ArtefactType->delete() at /home/kristina/code/16stable/htdocs/artefact/blog/lib.php:177
      ArtefactTypeBlog->delete() at /home/kristina/code/16stable/htdocs/artefact/blog/index.php:70
      delete_blog_submit(object(Pieform), array(size 3)) at Unknown:0
      call_user_func_array("delete_blog_submit", array(size 2)) at /home/kristina/code/16stable/htdocs/lib/pieforms/pieform.php:514
      Pieform->__construct(array(size 4)) at /home/kristina/code/16stable/htdocs/lib/pieforms/pieform.php:161
      Pieform::process(array(size 4)) at /home/kristina/code/16stable/htdocs/lib/pieforms/pieform.php:71
      pieform(array(size 4)) at /home/kristina/code/16stable/htdocs/artefact/blog/lib.php:411
      ArtefactTypeBlog::delete_form(78) at /home/kristina/code/16stable/htdocs/artefact/blog/index.php:44

  ---------------------

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1051495/+subscriptions