mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Yes it looks like a comment that starts off private then made public or
starts off public then made private does not respect the youngest
comment situation.

Looking at the code the 'youngest comment' is selected by last_public_comment() function, which wants the private = 0 and newest creation time. So when a comment changes from private = 0 to private = 1 the next youngest becomes the youngest.
So you can end up with two (or more) logically being allowed to be edited simply by adding some comments and then toggling the public/private checkbox for each latest 'public' one.

To fix we need to have a more robust check done in last_public_comment()
to take in account comments that have had public/private changed and if
they are pending moderation etc.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1183648

Title:
  Sometimes a comment becomes editable again

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  When you edit a comment, there's a notice on the editing screen saying
  that a comment is editable only as long as it is less than 10 minutes
  old and there is no younger comment after it. But I have noticed
  comments becoming editable again even after others are posted after
  them.

  I suspect it may be because clicking the "make public" link for a
  comment changes its "last edited" value to be newer than the date of
  the comments below it. If this is the case, we should check for
  "younger comments" by comment order, not by a date field.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1183648/+subscriptions