mahara-contributors team mailing list archive

[Mahara Bot <1253835@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2754
Committed: http://gitorious.org/mahara/mahara/commit/b7577ea86920e1b10b6a81a30ccb67664f353cda
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit b7577ea86920e1b10b6a81a30ccb67664f353cda
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Nov 27 15:46:46 2013 +1300

Making the profile page tabs work in responsive design (bug #1253835)

Because the profile tabs are created on the fly by javascript in
htdocs/artefact/internal/js/profile.js (which is mochikit) after the
page loads I couldn't use the exact same trick as other places in site.

Insetad I had to add the necessary dom elements and onclick toggle to
the tab block as they were being created.

And then got htdocs/js/rd-nav.js to check for the existance of profile
tab set and if exists deal with it like the others.

I also discovered all the instances where TABS heading was used
happened to be a hardcoded string so tidied that up also

Change-Id: I38a93ec8d06d05daed04406704590b5b1e1ac2fe
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1253835

Title:
  Make profile page tabs design responsive

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Other tabsets respect the responsive design rules - just not this set.

  -- reported by Evonne

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1253835/+subscriptions