mahara-contributors team mailing list archive

[Mahara Bot <1261233@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2803
Committed: http://gitorious.org/mahara/mahara/commit/044a5f39d96efbe44218f4f12360b1f46207aac3
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 044a5f39d96efbe44218f4f12360b1f46207aac3
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Mon Dec 16 11:19:07 2013 +1300

Allow a $cfg->bounces_ratio of 0

Bug 1261233: If you set the ratio to 0, you'll bounce someone
as soon as they hit bounces_min, regardless of what the sent/bounced
ratio is

Change-Id: Ibe8223054fa70ea27748d78b099afa079be7f900

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1261233

Title:
  Allow a VERP "bounces_ratio" of 0

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Our VERP bounce system has two parameters to determine when to disable
  someone's email. The absolute number of bounces must be greater than
  "bounces_min", and the ratio of bounces received versus emails sent,
  must be greater than "bounces_ratio".

  The problem is, on mahara.org we have some email addresses that have
  received thousands of emails, and others that have received less than
  a dozen. This makes the bounces_ratio feature not that useful; if we
  set it something like the default 0.2, then an email address that has
  been registered for years but has recently become invalid, will have
  to send us hundreds of bounce messages before we disable it.

  So, I want to disable the bouncesratio feature, by setting it to 0 (so
  that no matter what the ratio of sent to bounced is, it'll be higher
  than 0). However, check_overcount() short-circuits if *either*
  bounces_min or bounces_ratio is false, so I can't use 0 because it
  evaluates to false.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1261233/+subscriptions