mahara-contributors team mailing list archive

[Mahara Bot <1255378@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2813
Committed: http://gitorious.org/mahara/mahara/commit/6d784d9245cbfe340910cbd3ab46e36f562060d6
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    1.8_STABLE

commit 6d784d9245cbfe340910cbd3ab46e36f562060d6
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed Nov 27 15:14:41 2013 +1300

Fill in the missing implementation for find_key_name()

Bug #1255378

This fundamentally changes the behavior of find_key_name(). Before, it
only generated what the default name for the key would be, now it
actually checks whether a key of that description exists in the DB and
returns its actual name in the DB.

In core the method was only used by XMLDBGenerator in the methods for
dropping or altering a key, so this change will actually make it more
robust.

In theory, though, if there is third-party code relying on the current
behavior of find_key_name(), they could have problems.

Change-Id: I0470422a6e6514af98beb83e884178ee7f341ccd

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1255378

Title:
  Fill in the missing "key_exists()" method in ddl.php

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.8 series:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed

Bug description:
  For bug 1081947 we want to check whether some keys exist on certain
  tables in the database. We have an "index_exists" and
  "find_index_name" function in ddl.php to check for whether indexes
  exist, but just some TODO's in the corresponding "find_key_name"
  method.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1255378/+subscriptions