mahara-contributors team mailing list archive

[Mahara Bot <1253462@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2726
Committed: http://gitorious.org/mahara/mahara/commit/8bd31fc7fa5ff6cde9662951865d11b3559b5da2
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 8bd31fc7fa5ff6cde9662951865d11b3559b5da2
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Nov 21 11:51:37 2013 +1300

Checking for $user->urlid before trying to access it (bug #1253462)

In some cases the $user->urlid may not be present - this checks for it
before accessing it otherwise it falls back to the $id to get info

Change-Id: I989e68321402f458b167879e994150213c3e4893
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1253462

Title:
  Undefined property: stdClass::$urlid after doing feedback

Status in Mahara ePortfolio:
  In Progress

Bug description:
  I set up a new site and created a page as admin user. I added some
  feedback to page and then when I went to navigate away I got:

  [WAR] a0 (lib/user.php:1629) Undefined property: stdClass::$urlid
  Call stack (most recent first):

      log_message("Undefined property: stdClass::$urlid", 8, true, true, "/var/www/nyit-testing-mahara/releases/201311202206...", 1629) at /var/www/nyit-testing-mahara/releases/20131120220631/lib/errors.php:430
      error(8, "Undefined property: stdClass::$urlid", "/var/www/nyit-testing-mahara/releases/201311202206...", 1629, array(size 5)) at /var/www/nyit-testing-mahara/releases/20131120220631/lib/user.php:1629
      profile_url("2") at /var/www/nyit-testing-mahara/releases/20131120220631/artefact/comment/lib.php:538
      ArtefactTypeComment::build_html(object(stdClass)) at /var/www/nyit-testing-mahara/releases/20131120220631/artefact/comment/lib.php:383
      ArtefactTypeComment::get_comments(10, 0, "last", object(View), null) at /var/www/nyit-testing-mahara/releases/20131120220631/artefact/comment/lib.php:1152
      add_feedback_form_submit(object(Pieform), array(size 5)) at Unknown:0

  
  from what I could tell from the code the profile_url() call was fetching info about $user and that information was being called from get_user_for_display() and it was returning the $usercache info for the user but the $usercache did not have anything set for urlid

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1253462/+subscriptions