mahara-contributors team mailing list archive

[Mahara Bot <1255780@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2755
Committed: http://gitorious.org/mahara/mahara/commit/db4bc11bc4df8d322c8990c0a4f77158b7e7c422
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit db4bc11bc4df8d322c8990c0a4f77158b7e7c422
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Nov 28 14:26:18 2013 +1300

Getting the copy a page or collection to sort by collection
Bug #1255780

When clicking the 'Copy a collection' button on the
Portfolio -> Collections page the list of copyable pages is sorted by
collection name rather than page name to make it easier to see what pages are
in the collection that you are about to copy.

Also the subheading highlighted is 'Collections' instead of 'Pages'.

When clicking the 'Copy a page' link in Portfolio -> Pages things
should work like before.

- TODO: possibly limit each copyable collection to have one 'Copy
collection' button and have the alternating row colours toggle for
each collection rather than just each row.

Change-Id: I4b9786ba95404e03f44039cacb6e6b4bf6a4b0d6
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1255780

Title:
  copying collection needs to sort table by collection

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  Currently in Mahara if I have a collection (Portfolio -> Collections)
  and I click on the 'Copy a collection' button I am taken to
  view/choosetemplate.php?searchcollection=1 (which has Portfolio ->
  Pages menu highlighted rather than Portfolio -> Collections).

  The table of results is ordered by page name rather than collection
  name, then page name.

  From what I can tell the searchcollection=1 in the url does nothing. 
  Looking at the commit:  86d8cc21d40343cb4bcd4a827d0f55887a01f2ec
  It never did anything but could be utilised to 

  a) have the Portfolio -> Collections menu highlighted instead of Portfolio -> Pages when coming from collections
  b) make the table sort by collection, then pages instead of just pages

  I feel these changes would make for better user experience

  Another way to make things a bit easier to understand would be to have
  only one 'Copy collection' button in the table for each collection
  instead of one for each page in a collection. (similar to how Content
  -> Notes now works for which textboxes are in which pages).

  See collection table mockup of what I mean

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1255780/+subscriptions