← Back to team overview

mahara-contributors team mailing list archive

[Bug 1270683] Re: Don't append a number upon first copying of a page

 

Actually, no, on further inspection of the code, this would not happen.
After doing that query, the code goes on to use "in_array()" to check
whether the EXACT title you're requesting is in the array of returned
results.

So, the requested title "Air" would indeed find "Airlines of the 1950s"
in that query. But then when we ask "in_array('Air', $results)", we
would find that none of the pages exactly matches the title "Air", so
you'd be allowed to use it.

So yeah, it sounds like this one is probably a false alarm based on
inconsistent testing. I'll mark it invalid unless someone can provide
specific instructions to reproduce it.

** Changed in: mahara
       Status: Incomplete => Invalid

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1270683

Title:
  Don't append a number upon first copying of a page

Status in Mahara ePortfolio:
  Invalid

Bug description:
  When you have turned off "Copy of..." for pages ($cfg->renamecopies =
  false;), each page still gets a number appended even if that page /
  collection title does not yet exist in the user's portfolio.

  It would be better if a number would only be added to the title if the
  exact same title already existed.

  Tested on Mahara 1.8.

  See https://mahara.org/interaction/forum/topic.php?id=6013

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1270683/+subscriptions


References