← Back to team overview

mahara-contributors team mailing list archive

[Bug 1259764] A change has been merged

 

Reviewed:  https://reviews.mahara.org/2890
Committed: http://gitorious.org/mahara/mahara/commit/65e0743218cf3d53a11b4d90d7698636abfb7dc3
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 65e0743218cf3d53a11b4d90d7698636abfb7dc3
Author: Jono Mingard <jonom@xxxxxxxxxxxxxxx>
Date:   Wed Jan 8 14:24:19 2014 +1300

Use focus management in Feedback form (Bug #1259764)

"Place feedback" button should now focus the Message input of the Feedback
form. Also, if the Feedback block is used on a page, the feedback form is
moved so that it's under the "Place feedback" button in the HTML - this
means that the document stays in a logical order for screen reader users.

Change-Id: Ieeb71bc7b25e48b7b69683173c01cf1659e4144d
Signed-off-by: Jono Mingard <jonom@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1259764

Title:
  Feedback form should use focus management

Status in Mahara ePortfolio:
  In Progress

Bug description:
  When placing feedback on a page, the feedback form appears without
  reloading the page. For screen reader users this can be confusing, so
  the 'Message' text box should be explicitly focused when the "Place
  feedback" link is activated.

  Related: If feedback is a block on the page, the feedback form is
  still added to the footer (rather than to the block). Adding it after
  the "Place feedback" link would make the page order more logical to
  screen reader users.

  Affects latest master (using Orca 3.4.2)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1259764/+subscriptions


References