← Back to team overview

mahara-contributors team mailing list archive

[Bug 1273937] A change has been merged

 

Reviewed:  https://reviews.mahara.org/2973
Committed: http://gitorious.org/mahara/mahara/commit/2401c8844492b7c5e7cd51db3c79e3187bd1edea
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 2401c8844492b7c5e7cd51db3c79e3187bd1edea
Author: Jono Mingard <jonom@xxxxxxxxxxxxxxx>
Date:   Wed Jan 29 16:51:43 2014 +1300

Use <label> tags in skin designer (Bug #1273937)

Changed 'labelhtml' to 'title' in skin design form to allow the input
labels to use the <label> tag and therefore be accessible to screen
readers.
Modified the position choosers to have hidden labels and (hopefully)
fixed cross-browser inconsistencies in the layout.
Also modified the structure of the radio pieforms element to fix issues
with screen readers.

Change-Id: I8706c34e2c2a86b0f3d54b5f0c54d337ecc251a6
Signed-off-by: Jono Mingard <jonom@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1273937

Title:
  Skins form needs to use label elements

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  Child of Bug #1259756

  Currently the form to add/edit a skin has labels for most elements, but since they do not use the <label> tag they are not accessible to screen reader users.
  Also, the direction pickers (for background position etc.) need hidden labels.

  Affects latest master

  (WCAG Level A)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1273937/+subscriptions


References