← Back to team overview

mahara-contributors team mailing list archive

[Bug 1265253] Re: Check device detection and HTML editor use

 

MobileDetect's mobileGrade() method won't work for TinyMCE - it's too lenient. The key to TinyMCE support is contentEditable, which jQuery Mobile doesn't require. For example, contentEditable was only added to iOS in version 5, but iOS 3.1+ gets an 'A' grade in mobileGrade().
I would suggest testing in JavaScript using something like Modernizr's contentEditable test (https://github.com/Modernizr/Modernizr/blob/master/feature-detects/contenteditable.js) as IMO it would be more accurate and less complex than trying to detect it in PHP

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1265253

Title:
  Check device detection and HTML editor use

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara user manual:
  Confirmed

Bug description:
  Mahara 1.8 / master (1.9dev):

  When device detection is turned on, mobile devices do not display
  TinyMCE. When you turn it off, they do and some mobile devices can
  actually use TinyMCE. It would be good to check the current iOS and
  Android version to see if we still need to make the distinction when
  device detection is turned on or whether both states can use TinyMCE.

  I think our current lowest Android version is 2.3 which we might have
  to rethink as Android is now at 4.4.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1265253/+subscriptions


References