mahara-contributors team mailing list archive

[Mahara Bot <1265091@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2984
Committed: http://gitorious.org/mahara/mahara/commit/7d91d9477c60dfc6eb0e8af59e44e5ffbfed3caa
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 7d91d9477c60dfc6eb0e8af59e44e5ffbfed3caa
Author: Jono Mingard <jonom@xxxxxxxxxxxxxxx>
Date:   Tue Feb 4 17:37:47 2014 +1300

Redesigned elements with optional checkbox (Bug #1265091)

Color picker (used in skin designer) - moved 'transparent' checkbox
before color input field and changed the label to 'Custom'
Date picker - moved 'Not specified' checkbox before comboboxes and
changed the label to 'Set date'

Change-Id: I12e779cfdc06268f0f2ff494bf0753e066558686
Signed-off-by: Jono Mingard <jonom@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1265091

Title:
  Pieforms date elements should have "Not specified" before the date
  picker

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  The pieforms date picker (in lib/pieforms/pieform/elements/date.php) can have both a date picker (set of comboboxes) and a "Not specified" checkbox. However, it's confusing to screen reader users that the date comboboxes are displayed before the "Not specified" checkbox because if the comboboxes are disabled (ie. if the checkbox is initially checked) then they are not read out - so if a screen reader user unchecks the checkbox they have to tab backwards to get to the date selector.
  The position of the comboboxes and checkbox should be swapped so that when the checkbox is unchecked, the comboboxes are next in the tab order.

  The same goes for the "expiry" element - in this case the combobox
  should be displayed before the text box.

  Affects latest master

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1265091/+subscriptions