mahara-contributors team mailing list archive

[Mahara Bot <1212541@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3051
Committed: http://gitorious.org/mahara/mahara/commit/75797883be7b3ed7e32a039ca1434f51ade69519
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 75797883be7b3ed7e32a039ca1434f51ade69519
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Thu Feb 27 14:31:57 2014 +1300

Replace obsolete TinyMCE GoogleSpell with in-browser spellcheck as
default

Bug 1212541: The web service the TinyMCE GoogleSpell code was using,
is no longer in existence. This patch changes things so that TinyMCE will
let the browser's spellchecker work, by default.

The "pathtoaspell" is now null by default. If pathtoaspell is null, we
eliminate the TinyMCE spellcheck button and set the "gecko_spellcheck"
flag to let the browser spellcheck work. If pathtoaspell is not null,
we show the TinyMCE spellcheck button as before.

Change-Id: I9fd2b12169669d3d9705a1e23dc6c03af6f01948

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1212541

Title:
  GoogleSpell has been discontinued -- remove it from TinyMCE
  spellchecker

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  See https://tracker.moodle.org/browse/MDL-38867

  The TinyMCE spellcheck plugin in Mahara by default uses the local
  aspell program (if it's present at /usr/bin/aspell, or
  $cfg->pathtoaspell). If that's not present, it attempts to use the
  GoogleSpell spellcheck engine, which was based on a non-public Google
  API that was discontinued in the second quarter of 2013.

  We should follow suit with whatever approach Moodle decided on to deal
  with this.

  I'm not sure how many places will be affected by this. Those running
  their sites on Linux will have /usr/bin/aspell present. It may be
  absent or inaccessible for places running on shared hosting, though.

  For affected sites, a workaround would be to remove the spellcheck
  button from your TinyMCE by removing the word "spellchecker" from the
  list stored in the $adv_buttons variable in the smarty() function in
  htdocs/lib/web.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1212541/+subscriptions