mahara-contributors team mailing list archive

[Mahara Bot <1266317@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3070
Committed: http://gitorious.org/mahara/mahara/commit/0f026df2448784e1d2db41359de98b37dccfe243
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    1.8_STABLE

commit 0f026df2448784e1d2db41359de98b37dccfe243
Author: Mike Kelly <m.f.kelly@xxxxxxxxxx>
Date:   Tue Nov 19 11:24:11 2013 +0000

Restructure usr_custom_layout table to take groups into account

Bug #1266317

Group pages, site and institution pages were set as having usr = 0 in
usr_custom_layout because the view owner is null.

Fix by adding group column to table, foreign keyed to group table.

usr column and group column have to be changed to allow null values, and
to have null as default values.

When saving a custom layout, check context, then set usr and group
values accordingly.
e.g.
usr = 5, group = null
usr = null, group = 321
In the case of site and institution pages:
usr = null, group = null

Change-Id: Id42ebcc543d29ee2455aef73227b57c569171385
Signed-off-by: Mike Kelly <m.f.kelly@xxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1266317

Title:
  Institution/group ownership of custom flexible layouts

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.8 series:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed

Bug description:
  I came across a nasty bug in the mahara custom layouts feature.

  If a user saves a custom layout from within a group, the view owner is null, so usr in the usr_custom_layout table is set to be 0.
  This means that the saved custom layout becomes available to all users, so the advanced layout options area gets cluttered quite quickly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1266317/+subscriptions