mahara-contributors team mailing list archive

[Mahara Bot <1281121@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3058
Committed: http://gitorious.org/mahara/mahara/commit/84dfa408e62eec0f3c51002718b7394d0c60f6c2
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 84dfa408e62eec0f3c51002718b7394d0c60f6c2
Author: Robert Boloc <1281121@xxxxxxxxxxxxxxxxxx>
Date:   Mon Mar 3 07:44:43 2014 +1300

The $anonfeedback variable has not been used since v1.2 (Bug 1281121)

The only place that calls the get_view_from_token() does nothing with
the output. It is left over code from version 1.2 where the token was
checked to see if an anonymous user could add feedback to a view or
artefact.

The code changed completely in v1.3 where things like tutors came into
play so I've removed the legacy old code from view/artefact.php

Change-Id: Id1bf9732d87d4ac50ab2d12d1279b400d5f6ee30
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1281121

Title:
  Method view_has_token uses uninitialized variable

Status in Mahara ePortfolio:
  New

Bug description:
  This method is found in htdocs/lib/mahara.php staring on line 2089.

  The bug is that it uses a variable ($visible) that does not exist in
  the function context.

  I attach a patch with the fix.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1281121/+subscriptions