mahara-contributors team mailing list archive

[Mahara Bot <1249858@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3196
Committed: http://gitorious.org/mahara/mahara/commit/459d37af2a0eab3e2bc141fbc724b50781c40a3a
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    1.9_STABLE

commit 459d37af2a0eab3e2bc141fbc724b50781c40a3a
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Apr 3 09:46:30 2014 +1300

Prefer fileinfo detected mimetype over browser-supplied mimetype (Bug
#1249858)

Browsers can get the their mimetypes for certain things mixed up if
they visit badly written websites. So we should trust magicdb over
what the browser tells us.

Change-Id: I477580d55a70f7e2d03385897a6ec02166506908
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1249858

Title:
  Mahara can't figure out mime types because of a finfo() bug

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.6 series:
  In Progress
Status in Mahara 1.7 series:
  In Progress
Status in Mahara 1.8 series:
  Fix Committed
Status in Mahara 1.9 series:
  In Progress

Bug description:
  There have been several notable Mahara bugs based around the fact that
  our current handling of mimetypes is broken.

  See for instance:
   - https://bugs.launchpad.net/mahara/+bug/1220639
   - https://bugs.launchpad.net/mahara/+bug/1249166

  The problem is this:

  1. You can't really trust the mimetype that the browser sends to you, because different browsers send different wacky things
  2. Mahara has long used its own function file_mime_type() in lib/file.php for this purpose
  3. file_mime_type() preferentially uses finfo() to check the mimetype. But, there's a bug in finfo() with an external magic db, which is how it is distributed on Ubuntu presently: https://bugs.php.net/bug.php?id=61940
  4. file_mime_type() falls back to mime_content_type(). But that's now deprecated
  5. If neither of those works, we fall back to trusting what the browser told us, which isn't really the best (see #1)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1249858/+subscriptions