mahara-contributors team mailing list archive

[Mahara Bot <1305275@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3213
Committed: http://gitorious.org/mahara/mahara/commit/f3e612a552578081375d0a22c0815936f39ca645
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit f3e612a552578081375d0a22c0815936f39ca645
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Apr 10 08:13:47 2014 +1200

Colour form option not saving properly (Bug #1305275)

The 'customise' optional checkbox was breaking the saving of colours
for boxes without optional setting. This is due to the 'transparent'
being the default and the colour the optional choice.

Altered it so the colour is the default and choosing 'transparent' is
the optional choice for backwards compatibility.

Change-Id: I76e4f2f9557f3f3b8d3baf13cd35ac95d05618f2
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1305275

Title:
  custom theme goes white on save

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.9 series:
  Confirmed

Bug description:
  In master:

  If I save an institution with custom theme set it goes all white
  (#FFFFFF).

  The changes to the colour select box have broken things.

  Instead of opting out of using transparent one needs to opt in - and
  the custom theme colour choices do not have the opt out of using
  transparent checkbox.

  It will be better to switch this around and have the selecting of
  using transparent (inherit existing colour) on the skins editing page
  to be the checkbox option.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1305275/+subscriptions