mahara-contributors team mailing list archive

[Mahara Bot <1305481@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3240
Committed: http://gitorious.org/mahara/mahara/commit/b7551b324f9db36667905dfd6f90adc1ecbf34cd
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    1.9_STABLE

commit b7551b324f9db36667905dfd6f90adc1ecbf34cd
Author: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>
Date:   Fri Apr 11 09:54:59 2014 +1200

Remove old event handlers for blocks in accordion (Bug #1305481)

Change-Id: Ic144660524e7ef0108989f8064b034740f3848a3
Signed-off-by: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1305481

Title:
  Adding content to page buggy on Firefox

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.9 series:
  In Progress

Bug description:
  When adding a block by clicking an element from the content editor
  sidebar after a menu from the sidebar was expanded, the block gets
  added twice and the overlay doesn't go away.

  Steps to reproduce:

  1. Create a new page
  2. Go to Edit content -tab
  3. Expand a menu from the sidebar, for example Media
  4. Click "Text box" from the sidebar
  5. Click Save from the popup
  6. Click Save from the "Text box: Configure" popup

  Expected result:

  The popup and the overlay disappears and the Text box block is added
  to page.

  Actual result:

  The popup disappears, but the overlay remains and the block is added
  twice to page.

  In file js/views.js, the function ViewManager.makeNewBlocksDraggable
  is called on ViewManager initialization and also when the change event
  of the accordion is fired. So each div.blocktype gets a new click (and
  keydown) handler when the accordion is expanded and that's why
  ViewManager.startAddBlock is called multiple times and multiple
  overlays are created. We have made some customizations to views.js,
  but they don't seem to affect this part of the code.

  Mahara version: Latest from git (1.9rc2dev)
  Browser: Mozilla Firefox for Ubuntu (28.0)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1305481/+subscriptions