mahara-contributors team mailing list archive

[Mahara Bot <1300289@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3214
Committed: http://gitorious.org/mahara/mahara/commit/f4f888d5acff29ff6636ffe5674bd25f2f3de038
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    1.8_STABLE

commit f4f888d5acff29ff6636ffe5674bd25f2f3de038
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Apr 7 10:20:56 2014 +1200

Anonymous comments not showing the correct profile icon (Bug #1300289)

The anonymous comments should show the no_userphoto icon.

I've taken the patch supplied by Brian King and simplified it a bit so
that if no user is supplied to profile_icon_url it gives us the
no_userphoto icon rather than needing a new Dwoo function to handle
this.

Change-Id: I469fad4532b3ae91e1d673ec33d04d04c4fc3c7d
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1300289

Title:
  commentlist shows logged in user's icon for anonymous comments

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.8 series:
  In Progress
Status in Mahara 1.9 series:
  Fix Committed

Bug description:
  How to verify bug:

  * Share a view that allows comments with a secret URL 
  * As a non-logged in user, leave a comment
  * As the logged in user who shared the view, look at the comments on the view.  You will see your profile icon next to the link of the anonymous user's comment

  Mahara 1.8.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1300289/+subscriptions