mahara-contributors team mailing list archive

[Mahara Bot <1305451@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3272
Committed: http://gitorious.org/mahara/mahara/commit/1acaa689b01fe1964204b79273f856a14727edb1
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.9_STABLE

commit 1acaa689b01fe1964204b79273f856a14727edb1
Author: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>
Date:   Fri Apr 11 11:56:03 2014 +1200

Make sure the pop-up 'Add block' called once when click
Bug 1305451 and 1305481

MouseEvent.buttons is not defined in Chrome, use button insteads

Change-Id: Icf51e74ba64893925061e35e601fa40b4f761650
Signed-off-by: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1305451

Title:
  Content editor sidebar doesn't work on Chrome

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed

Bug description:
  Adding content by clicking an item from the sidebar fails on Chrome.

  Steps to repeat:

  1. Create a new page
  2. Go to Edit content -tab
  3. Click on Text box

  Expected result:

  "Add block: Text box" -popup appears.

  Actual result:

  Nothing happens.

  In file js/views.js, in function ViewManager.makeNewBlocksDraggable
  the event handler of the .blocktypelink -elements is assumed that
  event.buttons -property exists and that it is a number. However, as
  you can see from https://developer.mozilla.org/en-
  US/docs/Web/API/MouseEvent.buttons#Browser_compatibility, Chrome
  doesn't seem to support the property.

  Mahara version: Latest from git (1.9rc2dev)
  Browser: Chrome (Linux) 33.0.1750.152

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1305451/+subscriptions