mahara-contributors team mailing list archive

[Aaron Wells <1311940@xxxxxxxxxxxxxxxxxx>]

Okay, the problem here is that Jono's code change doesn't support an
obscure Pieforms feature that lets a form have multiple submit buttons,
each of which gets its own submit function.

If you create a form with multiple submit buttons, and you create a
function called {$formname}_submit_{$buttonname}(), then that function
will be called by pieforms if the user clicks that button. This is used
on exactly two forms: The profile picture picker, and the
admin/users/suspended.php form for unsuspended, unexpiring, or deleting
a user.

Notably, neither of these forms has a {$formname}_submit() method. And
the way Pieforms is written, it's supposed to return after hitting that
_submit() function, and if it doesn't return, it gets to the point where
it displays this error message.

So probably the solution here, is that if it goes to a button submit
function, it Pieforms should return.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1311940

Title:
  Error shown when changing your profile icon to default "Standard or
  external avatar"

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 1.10 series:
  In Progress
Status in Mahara 1.9 series:
  In Progress

Bug description:
  To replicate:

  1. Go to Content->Profile pictures
  2. Upload a profile picture
  3. Select that profile picture as your "Default" and click "Set default"
  4. Now, select the anonymous profile icon ("Standard or external avatar") and click "Set default"

  You'll see a red warning box at the top of the form that says "There
  was an error with submitting this form. Please check the marked fields
  and try again."

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1311940/+subscriptions