mahara-contributors team mailing list archive

[Mahara Bot <1311940@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3285
Committed: http://gitorious.org/mahara/mahara/commit/8c19958a783d3acc7620641767bda0a160237595
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 8c19958a783d3acc7620641767bda0a160237595
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Thu Apr 24 14:17:27 2014 +1200

Prevent global form error from incorrectly showing up on forms with
button-submit functions

Bug 1311940: There's an obscure pieforms feature where a form can have multiple submit
buttons, and each submit button can have its own submit callback function named
{formname}_submit_{buttonname}. These functions are supposed to redirect at the end.
If they don't, due to a bug in the implementation of the global form message we currently show
an error message at the top of the form saying there was something wrong with the user's
submission. Instead, we should just let the form go through, and log a debug message for
the devs.

Change-Id: Ib0e9b7e2f58737c9c736bdd1c033bc020985a60b

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1311940

Title:
  Error shown when changing your profile icon to default "Standard or
  external avatar"

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed

Bug description:
  To replicate:

  1. Go to Content->Profile pictures
  2. Upload a profile picture
  3. Select that profile picture as your "Default" and click "Set default"
  4. Now, select the anonymous profile icon ("Standard or external avatar") and click "Set default"

  You'll see a red warning box at the top of the form that says "There
  was an error with submitting this form. Please check the marked fields
  and try again."

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1311940/+subscriptions