← Back to team overview

mahara-contributors team mailing list archive

[Bug 1308857] A change has been merged

 

Reviewed:  https://reviews.mahara.org/3284
Committed: http://gitorious.org/mahara/mahara/commit/a5f784c729e471e34500311e0c43bb38778fa6a4
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.8_STABLE

commit a5f784c729e471e34500311e0c43bb38778fa6a4
Author: Kamaya Sho <s-kamaya@xxxxxxxxxxxxx>
Date:   Thu Apr 24 12:28:09 2014 +1200

Responsive navigation menu doesn't collapse in iPad in portrait mode

Bug 1308857. The problem appears to be that the collapse logic is based
around a <= and a >=, and the iPad in portrait mode falls right in the middle
so it triggers both. Changing this to a more logical <= and > pair fixes things.

Change-Id: Iacb8d53daff0f06a6f414bf5e4aafdee1337dfa3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1308857

Title:
  menu of the default theme does not close on the iPad

Status in Mahara ePortfolio:
  New
Status in Mahara 1.6 series:
  Fix Committed
Status in Mahara 1.7 series:
  Fix Committed
Status in Mahara 1.8 series:
  Fix Committed

Bug description:
  mahara varsion:1.8.2 
  device:iPad Air
  device OS :iOS7.1
  browser: safari

  When displayed in portrait orientation of the iPad mahara that set the
  default theme, there is a problem that does not close MENU.

  To be resolved by modifying the javascript as follows this.

  mahara / js / rd-nav.js: Line 48 
  before: 
  if (windowWidth> = navBuffer) {

  after: 
  if (windowWidth> navBuffer) {

  I hope that is reflected in the javascript of distributor :)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1308857/+subscriptions


References