mahara-contributors team mailing list archive

[Nathan Lewis <nathan.lewis@xxxxxxxxxxxxx>]

Hi Steven.

As I said, the conditions are described at the start of the first post:

 - User dashboard: Show activities that are of interest to the user. Items
shown here are affected by the user's Notification settings. Only items
that the user has access to will be displayed.
 - User page: Shows activities that the page owner has performed. The
contents of this block are filtered by the sharing permissions of the items
relative to the viewer. The owner will see all actions they have performed.
Any other user will show the actions that the owner performed, but only for
items that are shared with them.
 - Group and Institution pages: Show activities that relate to the group or
institution. The contents are filtered to only show items that are shared
with the viewer. It assumes that the user viewing the stream has access to
the group or institution.

All of that is currently limited by what Activity Types have actually been
implemented. As of this patch, there are only two notifications that the
user can set to the activity stream - new page access and new comment. I
chose those two because they were fairly easy for me and testers to
understand, showed how grouping of activities works, showed how activity
stream enabled Activity Types can be implemented or converted and allowed
me to test quite a broad section of the AS core query. Moises has a patch
in now which adds new friend notifications ("Your friend X is now friends
with Y") and I submitted new group member ("User X is now a member of group
Y"). The next one Moises adds will probably be new artefact access
(dependant on Yuliya's artefact access patch, giving "User X changed
sharing on [artefacttype] [artefactname]", for all shareable artefact
types).

You could have a look at blocktype/activitystream/lib.php to see how the
query works. I've added a lot of comments to make it clear what each step
is doing. Or ask if there's anything more that needs clarification.

Nathan


On 29 May 2014 15:07, Steven <stevens@xxxxxxxxxxxxxxx> wrote:

> In the how to test note that was added, you mentioned that "There are a
> bunch of different criteria that determine what should be in an Activity
> Stream." How many and what are the different criteria ?
>
> Catalyst QA Tester
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1316324
>
> Title:
>   Add activity stream block
>
> Status in Mahara ePortfolio:
>   Confirmed
>
> Bug description:
>   This is a bug to keep track of the Activity Stream block that we are
>   implementing.
>
>   The activity stream block which can be placed in any page and will
> display different content depending on the viewer and the type of the page:
>    - User dashboard: Show activities that are of interest to the user.
> Items shown here are affected by the user's Notification settings. Only
> items that the user has access to will be displayed.
>    - User page: Shows activities that the page owner has performed. The
> contents of this block are filtered by the sharing permissions of the items
> relative to the viewer. The owner will see all actions they have performed.
> Any other user will show the actions that the owner performed, but only for
> items that are shared with them.
>    - Group and Institution pages: Show activities that relate to the group
> or institution. The contents are filtered to only show items that are
> shared with the viewer. It assumes that the user viewing the stream has
> access to the group or institution.
>
>   This is a complicated patch, so here are some notes to help explain
>   things:
>
>   A 'homestream' notification plugin has been implemented. It is
>   basically a placeholder, as the processing of activities happens
>   within the activity stream block.
>
>   Activity types have to be updated to be able to be included in the
>   activity stream. We've got plans to implement a large set of new
>   activity types and refactor more of the existing activity types. This
>   first version (we intend to) only include refactors of two existing
>   activity types - "New page access" and "Feedback". Others will be
>   implemented after the initial patch is merged.
>
>   The code for selecting items to show in the activity streams is
>   complex and has been broken down into several smaller pieces to allow
>   for testing and easier maintenance. We've implemented a set of php
>   units tests to make sure that the correct activities are showing in
>   the correct streams. This testing is important because it ensures that
>   users will only see activities that they are entitled to see, to
>   maintain privacy.
>
>   All of the above is subject to change. Check the following comments.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mahara/+bug/1316324/+subscriptions
>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1316324

Title:
  Add activity stream block

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  This is a bug to keep track of the Activity Stream block that we are
  implementing.

  The activity stream block which can be placed in any page and will display different content depending on the viewer and the type of the page:
   - User dashboard: Show activities that are of interest to the user. Items shown here are affected by the user's Notification settings. Only items that the user has access to will be displayed.
   - User page: Shows activities that the page owner has performed. The contents of this block are filtered by the sharing permissions of the items relative to the viewer. The owner will see all actions they have performed. Any other user will show the actions that the owner performed, but only for items that are shared with them.
   - Group and Institution pages: Show activities that relate to the group or institution. The contents are filtered to only show items that are shared with the viewer. It assumes that the user viewing the stream has access to the group or institution.

  This is a complicated patch, so here are some notes to help explain
  things:

  A 'homestream' notification plugin has been implemented. It is
  basically a placeholder, as the processing of activities happens
  within the activity stream block.

  Activity types have to be updated to be able to be included in the
  activity stream. We've got plans to implement a large set of new
  activity types and refactor more of the existing activity types. This
  first version (we intend to) only include refactors of two existing
  activity types - "New page access" and "Feedback". Others will be
  implemented after the initial patch is merged.

  The code for selecting items to show in the activity streams is
  complex and has been broken down into several smaller pieces to allow
  for testing and easier maintenance. We've implemented a set of php
  units tests to make sure that the correct activities are showing in
  the correct streams. This testing is important because it ensures that
  users will only see activities that they are entitled to see, to
  maintain privacy.

  All of the above is subject to change. Check the following comments.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1316324/+subscriptions