← Back to team overview

mahara-contributors team mailing list archive

[Bug 1326630] A patch has been submitted for review

 

Patch for "master" branch: https://reviews.mahara.org/3411

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1326630

Title:
  integer/min/max rules do not allow for empty values

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Currently for some fields that limit the db output have
  integer/minvalue/maxvalue rules. But there is no ability to leave the
  field blank (so allowing for all  to be displayed). This is due to the
  rules on the field:

  'rules'        => array('integer' => true, 'minvalue' => 0, 'maxvalue'
  => 1000)

  But if we change to

  'rules'        => array('minvalue' => 0, 'maxvalue' => 1000)

  There is no check that any non blank entry is actually an integer.

  So I'll make a slight change to the minvalue/maxvalue rules to make
  sure any non blank entry fits with the logic of being an integer.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1326630/+subscriptions


References