← Back to team overview

mahara-contributors team mailing list archive

[Bug 1271778] A change has been merged

 

Reviewed:  https://reviews.mahara.org/3385
Committed: http://gitorious.org/mahara/mahara/commit/551a357684c92bd5b05741a143a377ef21bbc869
Submitter: Yuliya Bozhko (yuliya.bozhko@xxxxxxxxx)
Branch:    master

commit 551a357684c92bd5b05741a143a377ef21bbc869
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon May 26 12:42:09 2014 +1200

Orphaned label sorted out in certain places (Bug #1271778)

- Also includes fix to show profile tagged blogpost in profile block
with correct blog id

Change-Id: I5b6a3b844ad98b8c4bdb3fc02ebc4ae12af32847
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1271778

Title:
  Orphaned labels should be removed (changed to non-label tags)

Status in Mahara ePortfolio:
  In Progress

Bug description:
  The WAVE accessibility checker gives errors for <label> tags which
  don't have a 'for' attribute. Although this doesn't seem to be
  required by the WCAG specification itself, it would be nice to remove
  these so that Mahara's pages validate properly.

  Affects the following areas
  - Pieforms labels when the element doesn't use the correct ID (eg. for radio buttons the automatically generated label ends up not linking to anything)
  - Profile sideblock ("My Groups" and "Artefacts" use the label tag unnecessarily)
  - When editing the pages in a collection, the page titles use the label tag unnecessarily (it would be nice to change them to headings)
  - On a group's "About" page the statistics ("Created", "Members", etc) use the label tag
  - On a group's "Forums" page the "Group administrators" text uses the label tag

  In all these cases the label tag should be changed to something more
  appropriate (<strong>, <h3>, etc) or the "for" attribute should be
  removed and aria-labelledby added to any elements which the label
  should describe

  Affects latest master

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1271778/+subscriptions


References