mahara-contributors team mailing list archive

[Mahara Bot <1328760@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3459
Committed: http://gitorious.org/mahara/mahara/commit/82c845d95cb719a32b8ac2647babd4d0b2739c9e
Submitter: Yuliya Bozhko (yuliya.bozhko@xxxxxxxxx)
Branch:    master

commit 82c845d95cb719a32b8ac2647babd4d0b2739c9e
Author: Nathan Lewis <nathan.lewis@xxxxxxxxxxxxx>
Date:   Tue Jun 24 13:12:37 2014 +1200

Reverting activity stream patches (Bug #1316324)

Content from the following commits was reverted:

Patch 3327: 7a7673c052687558e4dd1df0286c938069ed26df
"Add activity stream block (Bug #1316324)"

Patch 3374: c538c7451be5076764ec6440a49331768a13414f
"Add likes to activity streams (Bug #1321480)"

Patch 3432: 121e90279fb8f72d81f47c5302726b6a93b7c776
"Add new parameters to the get_activity_body function (Bug #1328729)"

Patch 3434: 2e47dfb1d51368767f27316172c270cb1b8405c4
"Improvements to activity stream body helper (Bug #1328760)"

Change-Id: Id03c156a7c8c016c8dc76c998a73310ea57fe0a5
Signed-off-by: Nathan Lewis <nathan.lewis@xxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1328760

Title:
  Improvements to activity stream body helper

Status in Mahara ePortfolio:
  Won't Fix

Bug description:
  Aaron reported the following when reviewing the activity stream block
  patch:

  1. There are some strings with counts in them that need to be changed
  to the flexible plural format.

  2. There's a big chain of if-elses in lib/activity.php starting on
  line 1055, which are for sending different sets of parameters to
  get_string depending on what was passed in. I suspect we may be able
  to reduce that by using sprintf positional parameters.

  The patch will fix the above and more. The changes include the
  following:

  - Removed the big if-then-else statement. Now, all params are passed to all activity stream strings and the string specifies which params to use where, using parameter position notation (e.g. "%1$d"). As a result of this there was a lot of simplification of the code (not just the big "if").
  - Made several strings pluralized where applicable.
  - The 'viewer' can be passed in to the helper function. All strings in the helper now user the specified user's language, rather than defaulting to $USER.
  - In ActivityTypeArtefactCommentFeedback, the object type name is now being calculated using ActivityType::get_object_type_name, which simplifies the code.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1328760/+subscriptions