mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #19638
[Bug 1307247] A change has been merged
Reviewed: https://reviews.mahara.org/3332
Committed: http://gitorious.org/mahara/mahara/commit/3b0382ef3d414b038cc51955faea2989c13d2f5f
Submitter: Yuliya Bozhko (yuliya.bozhko@xxxxxxxxx)
Branch: master
commit 3b0382ef3d414b038cc51955faea2989c13d2f5f
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date: Wed May 7 10:51:43 2014 +1200
Allowing feedback notifications on group pages (Bug #1307247)
In this patch:
- Changed the Group Edit 'General' section and added the 'Feedback
notifications' options.
- Changed the Group Edit 'General' section and altered the 'Shared
page' option from tickbox to select options.
- Changed the CommentFeedback to be able to notify multiple users in a
group
- Changed the CommentFeedback to be able to send message in the
institution lang if needed.
- Adjusted group_get_editroles_options() to allow it to return a non
associative array
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Change-Id: Ia2e995c51aa08610945788e55c809b3c650dcd17
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1307247
Title:
No notifications on pages/artefacts for groups/institutions
Status in Mahara ePortfolio:
In Progress
Bug description:
Currently if a user leaves feedback on a group or institution page /
artefact there is no notifications sent out to interested parties.
The problem exists in ActivityTypeArtefactCommentFeedback
(artefact/comment/lib.php) on approx line 1205 where if there is no
owner id it doesn't follow thru to the sending of notifications. This
needs to be changed so that groups/institutions also get
notifications.
Currently the notification is only designed to be sent to the first
user in an array of users (containing only one user, the owner of
page/artefact). This will need to change so that it can actually loop
through users if there is more than one to be notified for
groups/institutions.
The question is who are the users that need to receive the feedback
notification? Is it the group/institution admins? all members?
Institution staff (for institutions)? Only those users in
group/institution watching the page?
I'm not sure to whom we should restrict the comment notification
message - please feel free to add suggestions to this bug report.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1307247/+subscriptions
References