mahara-contributors team mailing list archive

[Mahara Bot <1338394@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3481
Committed: http://gitorious.org/mahara/mahara/commit/c34857eec2e3e53343cf0078627b95e78a0b42c1
Submitter: Yuliya Bozhko (yuliya.bozhko@xxxxxxxxx)
Branch:    master

commit c34857eec2e3e53343cf0078627b95e78a0b42c1
Author: Nigel Cunningham <nigelc@xxxxxxxxxxxxxxx>
Date:   Mon Jul 7 11:30:46 2014 +1000

(Bug 1338394) Profile TinyMCE visibility issue

This patch addresses an issue wherein TinyMCE will incorrectly
appear on the profile edit page if a user enters a new email
address that fails validation.

Change-Id: I4197062276e2227d9003599249189c5dcb06e632
Signed-off-by: Nigel Cunningham <nigelc@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1338394

Title:
  Tinymce editor can incorrectly appear in profile edit page

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  Mahara version: Master/HEAD
  OS: Linux with FF30, Windows Vista with IE 9

  The upgrade to TinyMCE 4.0.16 (Bug #1282341) added
  htdocs/js/tinymce/skins/lightgray/skin.min.css.

  This file includes css:

  .mce-tinymce {
      position: relative;
      visibility: visible !important;
  }

  On the profile edit page (http://mahara/artefact/internal/index.php),
  the only TinyMCE editor in use appears in the first tab, and therefore
  doesn't normally cause any noticable issue.

  If a user tries to add an email address via the second tab and their
  address fails the validation, the Profile page will reload with the
  focus being on the second tab. After a brief delay, the TinyMCE editor
  from the Introduction field on the first tab will appear over the top
  of the email address fields.

  The editor appears because the non-selected tabs don't have the
  'collapsed' class added to them at the time the page is loaded.
  Instead, the safe-hidden class only is applied. The collapsed class is
  effective in hiding the editor and the safe-hidden class isn't.

  I've looked into the git history and Googled the 2 class names, and I
  couldn't get a clear understanding as to which there are 2 classes. I
  assume it's somehow related to browser differences, and have therefore
  provided a simple, minimal patch that ensures both classes are applied
  to tabs or neither is applied. In my testing on Firefox and IE 9, this
  addressed the observed bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1338394/+subscriptions