← Back to team overview

mahara-contributors team mailing list archive

[Bug 1315960] A change has been merged

 

Reviewed:  https://reviews.mahara.org/3313
Committed: http://gitorious.org/mahara/mahara/commit/7af04a15caa0845f1a0edfa4be5e87079dd65c2c
Submitter: Yuliya Bozhko (yuliya.bozhko@xxxxxxxxx)
Branch:    master

commit 7af04a15caa0845f1a0edfa4be5e87079dd65c2c
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon May 5 11:02:03 2014 +1200

Default category first item not always key '0' (Bug #1315960)

If no category with key = '0' it causes an error so we need to get
first item in array rather than item with key = 0

Change-Id: I4c8adc45944704205fccbdaa3259ad27998b9430
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1315960

Title:
  get_default_category() not robust enough

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  when testing out a new plugin I found the check in
  View->get_default_category() caused problems if there was nothing set
  with sort order = 0 or if the blocktypes of the item with sort order =
  0 were hidden on extensions page.

  The problem stems from not trying to get the first item in array but
  the item with key = 0.

  will add patch for fix

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1315960/+subscriptions


References