mahara-contributors team mailing list archive

[Nigel Cunningham <nigelc@xxxxxxxxxxxxxxx>]

I have another suggestion, with a patch that I've just pushed.

The required fields form works by hijacking any link that the user has
requested, so all we need to do after the user has successfully
addressed the requirements is drop out of generating the form and let
the normal execution for the requested URL continue. My patch
accomplishes that by adding a small amount of code allowing this to
happen. It relies on the fact that $form->build() always returns a
string (the rendered HTML), and instead returns FALSE if we need to back
out of the form generation.

I've successfully tested it by running an install on the URL
http://mahara, which causes the warning about the noreply email address.
I then clicked on the noreply link (fixed by the first patch of the two
in the submission) and was taken to the site_options URL, overridden by
the required fields form. After the required fields form was submitted
with a valid admin password, the page loaded with the requested form for
setting the noreply link.

At the point where I clicked on the noreply link, I also clicked on
other links, opening them in other tabs. All tabs displayed the required
fields form under the requested URL, as expected. After successful
submission on one of the tabs, reloading all other tabs then displayed
the expected page content.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/946880

Title:
  Broken html error message for no-reply email setting

Status in Mahara ePortfolio:
  Triaged

Bug description:
  error message when upgrading from 1.4 to 1.5:

  The noreply address setting is either empty or has an invalid email
  address. Please check the configuration in the <a
  href="http://15stable/admin/site/options.php?fs=emailsettings";>site
  options in the email settings</a>.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions