mahara-contributors team mailing list archive

[Mahara Bot <1353759@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3622
Committed: http://gitorious.org/mahara/mahara/commit/73b0ff0679d76bbd402238fd3b969ee403f191ff
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 73b0ff0679d76bbd402238fd3b969ee403f191ff
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Aug 8 12:18:41 2014 +1200

More Google maps urls not working in Google Apps block (Bug #1353759)

Was not working for urls with @ latitutude,longitude, zoom eg:
https://www.google.com/maps/@37.509345,-121.9596665,12z

And not working for shorthand ulrs like https://goo.gl/maps/pZTiA

So I've added a check for the urls with @ latitutude,longitude, zoom
and turned them into an acceptible embed url. And for shorthand urls
I've added a generic function to fetch the url the short one resolves
to and so it can parse that one instead of the short url.

Change-Id: I3c76d2608e9708f1722e243cdc02a43f1885b815
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1353759

Title:
  Google maps embed not working in Google Apps block

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 1.10 series:
  In Progress
Status in Mahara 1.7 series:
  New
Status in Mahara 1.8 series:
  New
Status in Mahara 1.9 series:
  New

Bug description:
  This is a follow-on from bug #1323495. Although just fixed, I can't
  embed a map via URL or embed code because my URL and embed code look
  different:

  URL: https://www.google.com/maps/@37.509345,-121.9596665,12z

  Embed:
  <iframe src="https://www.google.com/maps/embed?pb=!1m14!1m12!1m3!1d101278.0640639198!2d-121.95966649999998!3d37.509345!2m3!1f0!2f0!3f0!3m2!1i1024!2i768!4f13.1!5e0!3m2!1sen!2sus!4v1407372776473"; width="600" height="450" frameborder="0" style="border:0"></iframe>

  Short URL should also work:
  https://goo.gl/maps/pZTiA

  Tested on Mahara 1.9.2.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1353759/+subscriptions