mahara-contributors team mailing list archive

[Mahara Bot <1312672@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3295
Committed: http://gitorious.org/mahara/mahara/commit/10f3d44f32c62e985644c42ed5423be05153436e
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 10f3d44f32c62e985644c42ed5423be05153436e
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Apr 29 14:52:26 2014 +1200

Allowing the 'install font' to take a zip file (Bug #1312672)

When installing a normal font you have to select 4 or 5 different
files to be allowed to install the font - and most often you get these
files from 'fontSquirrel generator' in a zip file.

I've altered it so that you can either upload each file individually
or you can upload a zip file.

Change-Id: I381b2a06cf4e82c6c7bdb7b5413c620aa98eb467
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1312672

Title:
  Import one font into Mahara fails

Status in Mahara ePortfolio:
  Fix Released

Bug description:
  After several tries to import a font file, I noticed that I
  mistranslated the information on the Install Font page. So the end of
  my bug report is irrelevant.

  But, I think that because all the file format are required to import a
  single font, the explanation text should be more clear (maybe some
  text in bold?) and all the field must be specified as required (bold
  red *).

  -dajan


  <- the below part of this message became irrelevant / kept for history
  purpose --->

  Bug 1 - A licence file seems to be needed to import a font but no
  information (*) is displayed to tell the user about it before the
  importation fails with the message : "This file is required".

  Bug 2 - Even if a licence file is selected together with a font file, errors messages are still displayed
    - no file selected
    - this is not a valid xxx font file

  Procedure 1 :

  1/ Go to Administration -> Configure site -> Fonts
  2/ Click on Install font
  3/ Give a name (eg. Huxtable)
  4/ Leave everything else like it is
  5/ Select a TTF font file (e.g. the one attached to this bug report : Huxtable -> huxtable.ttf)
  6/ Click on the "Install font" button

  Expected behaviour :

  The font is installed with the given name.

  Real behaviour :

  The follwing error messages are displayed :
     a/  This is not a valid EOT font file. (with no file selected in red)
     b/ This is not a valid SVG font file. (with no file selected in red)
     c/ This is not a valid WOFF font file. (with no file selected in red)
     d/ License file This field is required.

  Procedure 2

  1/ Repeat steps 1 to 5 of procedure 1
  2/ Select a file for the licence (e.g. readthis.html)
  3/ Click on "Install font" button

  Expected behaviour :

  The font is installed with the given name.

  Real behaviour :

  Same as in procedure 1 but without the error message : Licence file
  This field is required.

  Propositions :

  1/ Mark the field "Licence" as required (bold red *)
  2/ Check if one file is selected and import it. If more than one file is selected import them. If no file is selected display an error message

  -dajan

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1312672/+subscriptions