mahara-contributors team mailing list archive

[Aaron Wells <1355572@xxxxxxxxxxxxxxxxxx>]

** Description changed:

  There are a few places which do this:
  
  if (strpos($jsfile, 'http://' === false)) { ...
  
  when they should do this:
  
- if (stripos($jsfile, 'http://' === false) && stripos($jsfile, 'http://'
+ if (stripos($jsfile, 'http://' === false) && stripos($jsfile, 'https://'
  === false)) { ...
  
  the problem only reveals itself on https sites where the wwwroot is in a
  subdirectory such as https://mysite/mahara/.
  
  The result is that the URL to include files is wrong so the files aren't
  loaded.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1355572

Title:
  Blocktype JS includes not loaded correctly on https sites using
  subdirectory for wwwroot

Status in Mahara ePortfolio:
  New

Bug description:
  There are a few places which do this:

  if (strpos($jsfile, 'http://' === false)) { ...

  when they should do this:

  if (stripos($jsfile, 'http://' === false) && stripos($jsfile,
  'https://' === false)) { ...

  the problem only reveals itself on https sites where the wwwroot is in
  a subdirectory such as https://mysite/mahara/.

  The result is that the URL to include files is wrong so the files
  aren't loaded.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1355572/+subscriptions