mahara-contributors team mailing list archive

[Mahara Bot <1355572@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3627
Committed: http://gitorious.org/mahara/mahara/commit/01072e9f7cd24f2537b21c947418176e573ebad8
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 01072e9f7cd24f2537b21c947418176e573ebad8
Author: Simon Coggins <simon.coggins@xxxxxxxxxxxxx>
Date:   Tue Aug 12 15:26:01 2014 +1200

(Bug1355572) Fix broken blocktype JS includes for https sites in
subdirectories

Change-Id: I88bbb537d94d2bb3c9a96f2ac721b629f64cd003
Signed-off-by: Simon Coggins <simon.coggins@xxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1355572

Title:
  Blocktype JS includes not loaded correctly on https sites using
  subdirectory for wwwroot

Status in Mahara ePortfolio:
  In Progress

Bug description:
  There are a few places which do this:

  if (strpos($jsfile, 'http://' === false)) { ...

  when they should do this:

  if (stripos($jsfile, 'http://' === false) && stripos($jsfile,
  'https://' === false)) { ...

  the problem only reveals itself on https sites where the wwwroot is in
  a subdirectory such as https://mysite/mahara/.

  The result is that the URL to include files is wrong so the files
  aren't loaded.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1355572/+subscriptions