← Back to team overview

mahara-contributors team mailing list archive

[Bug 1358912] A change has been merged

 

Reviewed:  https://reviews.mahara.org/3668
Committed: http://gitorious.org/mahara/mahara/commit/42a3cc9624e8eb118c51439602fe85d270c931de
Submitter: Ghada El-Zoghbi (ghada@xxxxxxxxxxxxxxx)
Branch:    master

commit 42a3cc9624e8eb118c51439602fe85d270c931de
Author: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>
Date:   Wed Aug 27 16:33:34 2014 +1200

Use strpos() insteads of substr_count(). Bug 1358912

Change-Id: I68c42ecc0e9e3b03d3fd6e09468ce82407fdef70
Signed-off-by: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1358912

Title:
  Syntax error when using a logo by id for theme logo

Status in Mahara ePortfolio:
  In Progress

Bug description:
  The <link> tag url ends up with two ? in it - eg <link rel="image_src"
  href="http://test.site.com/thumb.php?type=logobyid&amp;id=174958?v=1.9.2";>

  It doesn't cause an error but is bad syntax so should be fixed

  To test: edit an institution and add logo then login as a user from
  that institution - then view source of the page and look for
  'image_src'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1358912/+subscriptions


References