← Back to team overview

mahara-contributors team mailing list archive

[Bug 1360943] A change has been merged

 

Reviewed:  https://reviews.mahara.org/3659
Committed: http://gitorious.org/mahara/mahara/commit/edd26c95385f67bec1a41c6d703c7589c39f28f1
Submitter: Ghada El-Zoghbi (ghada@xxxxxxxxxxxxxxx)
Branch:    master

commit edd26c95385f67bec1a41c6d703c7589c39f28f1
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Aug 25 12:15:23 2014 +1200

Adjusting the save_config_options() call to include $form (Bug #1360943)

To be more like the validate_config_options() call and so allow for
something other than the generic success message.

Change-Id: I36a6fec227c525776b58fd29c1548fb30b62a92c
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1360943

Title:
  In admin extensions the save_config_options function lacks the $form
  attribute

Status in Mahara ePortfolio:
  In Progress

Bug description:
  There is no easy way to do a specific $form->json_reply() when saving
  an Admin -> Extensions config form.

  For each plugin it defaults to a generic 'Saved successfully'.

  I plan to adjust how this works so that it passes in the Pieform $form
  so that one can specify a special return success message, or default
  to generic one if no special one supplied.

  This is needed for Bug 1339113.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1360943/+subscriptions


References