mahara-contributors team mailing list archive

[Aaron Wells <1372188@xxxxxxxxxxxxxxxxxx>]

Hm, check_upgrades() should only add the "settings" array to the output
if it is run with a null parameter, not if it's run for a specific
plugin like in your example. I'll take a look, maybe it's not acting the
way I meant it to.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1372188

Title:
  upgrade problem with having the settings array

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Now that we have a 'settings' array in check_upgrades() it can never
  return false so if we do something like

          if ($data = check_upgrades('blocktype.text')) {
              upgrade_plugin($data);
          }

  it will fail if it's already installed as it returns the 'settings'
  array

  So we need to add to the upgrade_plugin() function a check to see if
  $upgrade->name has been passed otherwise bail out

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1372188/+subscriptions