mahara-contributors team mailing list archive

[Mahara Bot <1372188@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3708
Committed: http://gitorious.org/mahara/mahara/commit/d4b6416f496e022f1f54e6bcc4b1906a48ccd3e9
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit d4b6416f496e022f1f54e6bcc4b1906a48ccd3e9
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Mon Sep 22 18:43:11 2014 +1200

Make check_upgrade() return an empty array if requested plugin doesn't
need an update

Bug 1372188: If you supply a component for check_upgrade() to query and the component
doesn't need an upgrade, it's supposed to return an empty array. It was instead returning
an array with a "settings" component.

Change-Id: I01d2406605eacb0b48681317beb969311a06064b

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1372188

Title:
  upgrade problem with having the settings array

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  Now that we have a 'settings' array in check_upgrades() (see Bug
  1367998) it can never return false so if we do something like

          if ($data = check_upgrades('blocktype.text')) {
              upgrade_plugin($data);
          }

  it will fail if it's already installed as it returns the 'settings'
  array

  So we need to add to the upgrade_plugin() function a check to see if
  $upgrade->name has been passed otherwise bail out

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1372188/+subscriptions