mahara-contributors team mailing list archive

[Aaron Wells <1372536@xxxxxxxxxxxxxxxxxx>]

Right, so although this problem has (in theory) existed for artefact and
interaction plugins for a while, none of the artefact or interaction
plugins in core, includes any top-level menu items, and so the problem
hasn't displayed itself.

However, since modules are meant to be more generic, they should be able
to add top-level menu items. So we do need to fix this for modules, and
we may as well fix it for artefacts and interactions as well.

So I agree, probably the best thing is to create a second method
specifically for the right nav menu items. We'll have to consider
whether that will break backwards-compatibility for any existing
plugins, though. (i.e. are any existing plugins passing back right-nav
menu items in their menu_items() function?)

** Changed in: mahara
    Milestone: None => 1.10.0

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1372536

Title:
  PluginModule-menu items appear in two menus

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  With a module-plugin, that overwrites menu_items, the returned menu
  items appear in the main navigation and also in the top right corner.
  Both are very helpful on their own, but it should be possible to add
  an item to either of them without the other, like, have an entry only
  in the upper right corner but not in the main menu or vice versa.

  The calls are indistinguishable (as far as I see) and originate from
  web.php::main_nav, line 2683 and web.php::right_nav, line 2741

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1372536/+subscriptions