← Back to team overview

mahara-contributors team mailing list archive

[Bug 1372536] Re: PluginModule-menu items appear in two menus

 

I could imagine that there are plugins who add submenu items to the user settings, which are part of the right nav menu. I'll see if I can include those submenu-entries but skip all top-level items when calling menu_items for the right-nav and then add a function to the three plugin types to add to the right nav menu. That would mean two ways to add elements to the right-nav menu for the moment, but it wouldn't break any existing plugin. 
In how far do we support plugins that are not listed under https://wiki.mahara.org/index.php/Plugins ? We could skip the workaround when starting the work on 1.11 so developers will have enough time to fix their plugins. And I'll have a look at the plugin list in the wiki.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1372536

Title:
  PluginModule-menu items appear in two menus

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  With a module-plugin, that overwrites menu_items, the returned menu
  items appear in the main navigation and also in the top right corner.
  Both are very helpful on their own, but it should be possible to add
  an item to either of them without the other, like, have an entry only
  in the upper right corner but not in the main menu or vice versa.

  The calls are indistinguishable (as far as I see) and originate from
  web.php::main_nav, line 2683 and web.php::right_nav, line 2741

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1372536/+subscriptions


References