mahara-contributors team mailing list archive

[Mahara Bot <1371460@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3773
Committed: http://gitorious.org/mahara/mahara/commit/f4e41b7173733aa47e5c26eab9a240d3dea2475a
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.10_STABLE

commit f4e41b7173733aa47e5c26eab9a240d3dea2475a
Author: Tobias Zeuch <tobias.zeuch@xxxxxxx>
Date:   Mon Sep 22 16:36:19 2014 +0200

enable translation for strings in customlayout.js

Bug 1371460: Some strings still where hard coded in English in
htdocs/js/customlayout.js. This patch puts them into
lang/en.utf8/view.php for translation and adds them to the smarty-
template in layout.php

Change-Id: I182673f18de2ca5d50d4cfa0f4461a4699695bd5
Signed-off-by: Tobias Zeuch <tobias.zeuch@xxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1371460

Title:
  Missing translations in js/customlayout.js

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.8 series:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed

Bug description:
  In the file htdocs/js/customlayout.js there are hard-coded English
  language strings.

  "Row %s" on line 11: $(newrow).find('.customrowtitle').html('<strong>Row ' + (numrows + 1) + '</strong>');
  "Row %s" on line 39: $(this).find('.customrowtitle').html('<strong>Row ' + inc + '</strong>');
  "%s rows" (note this one's a plural string) on line 112:  rowtitlediv.html('<strong>' + numrows + ' rows</strong>');
  "Generating preview..." on line 224: $('#custompreview').html('<p>Generating preview...</p>');

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1371460/+subscriptions