mahara-contributors team mailing list archive

[Mahara Bot <1379086@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3794
Committed: http://gitorious.org/mahara/mahara/commit/1a122c09c1742751d00bd39832f2f1322debf788
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.10_STABLE

commit 1a122c09c1742751d00bd39832f2f1322debf788
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Oct 10 09:29:17 2014 +1300

Changed alert popup to warn message (Bug #1379086)

If you add a page by drag/drop it adds a warn for each time due to it
being a one item only transaction

If you add one or more pages by checkbox/submit it gives a digest of
the pages changed in the warn message

Change-Id: Ifccccca2c8de9fe4b1a4c2919a290c68f594dff4
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1379086

Title:
  Change the "Access permissions have changed" notification from a JS
  popup to an inline  CSS thing

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  One of the neat features we added in Mahara 1.10, was the ability to
  drag & drop pages into a collection.

  However, we also added a Javascript popup that comes up with each
  dragged page, if the permissions for the page will change now that
  it's in the collection.

  Example:

  1. Create Page 1 & Page 2
  2. Put Page 1 into Collection A
  3. Set Collection A to be visible to the public
  4. Drag Page 2 into Collection A

  With all due respect, this notification is pretty annoying, and it
  kinda cancels out all the added utility that we got from implementing
  drag-and-drop, because often you have to click it after every single
  added page. (It also hurts our "number of clicks to get things done"
  metric.) And in Firefox if a page gives you JS pop-ups more than a few
  times, Firefox itself adds a tickbox to let you ignore further pop-
  ups, which I'm betting will confuse users and make them think their
  site is broken somehow.

  If we must have a message telling users that the pages' permissions
  have changed, let's do it as an inline notice like the one you see on
  the Content -> Files page after you upload a file and it says "Upload
  of ___ complete". It shouldn't be green like that one, or red like an
  error notice. Perhaps the yellow "warning" styling that we use on the
  Admin Home page for site config warnings would be appropriate.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1379086/+subscriptions