mahara-contributors team mailing list archive

[Eduardo <eduardo@xxxxxxxxxxxxxxx>]

Tested on Mahara version (1.9.3testing). Path works and here is a
detailed method for my testing.

1. Log in as admin
2. Go to Portfolio
3. Click on Create page →  Page Title “Testing Bug”
4. Save
5. Click on Media → Image gallery type in the block
6. Under “Image selection”, select Display all images from one of my folders (will include images uploaded later)
7. Style → Thumbnails
8. Set width to “blank” (previous value was 75)
9. Save
10. Click on image gallery settings icon → Confirm width has gone back to 75 → Passed
11. Select another Image gallery type in the block
12. Under “Image selection”, select Display all images from one of my folders (will include images uploaded later)
13. Style → Thumbnails (square)
14. Set width to “blank” (previous value was 75)
15. Save
16. Click on image gallery setting icon → Confirm width has gone back to 75 → Passed
17. Select another Image gallery type in the block
18. Under “Image selection”, select → Display all images from one of my folders (will include images uploaded later)
19. Style → Slideshow
20. Set width to “blank” (previous was 400)
21. Save
22. Click on image gallery setting icon → Confirm width has gone back to 400→ Passed
23. Select another Image gallery type in the block
24. Under “Image selection”, select Choose individual images to display
25. Style → Thumbnails
26. Set width to “blank” (previous value was 75)
27. Save
28. Click on image gallery setting icon → Confirm width has gone back to 75 → Passed
29. Select another Image gallery type in the block
30. Under “Image selection”, select Choose individual images to display
31. Style → Thumbnails (square)
32. Set width to “blank” (previous value was 75)
33. Save
34. Click on image gallery setting icon → Confirm width has gone back to 75 → Passed
35. Select another Image gallery type in the block
36.  Under “Image selection”, select Choose individual images to display
37. Style → Slideshow
38. Set width to “blank” (previous value was 400)
39. Save
40. Click on image gallery setting icon → Confirm width has gone back to 400 → Passed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1366622

Title:
  width of gallery not set correctly

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.11 series:
  Fix Committed
Status in Mahara 1.9 series:
  Confirmed

Bug description:
  When creating an image gallery, a user can 'blank' out the 'Width'
  field.

  When the block is instantiated, the $configdata['width'] is set but
  it's empty.

  So, the $width is also empty.

  i.e. $width = isset($configdata['width']) ? $configdata['width'] : 75;

  I think the switch at the top should also check for '&&
  $configdata['width'] > 0':

  i.e.

  switch ($style) {
  case 0: // thumbnails
  $template = 'thumbnails';
  $width = isset($configdata['width']) && $configdata['width'] > 0 ? $configdata['width'] : 75;
  break;
  case 1: // slideshow
  $template = 'slideshow';
  $width = isset($configdata['width']) && $configdata['width'] > 0 ? $configdata['width'] : 400;
  break;
  case 2: // square thumbnails
  //default:
  $template = 'squarethumbs';
  $width = isset($configdata['width']) && $configdata['width'] > 0 ? $configdata['width'] : 75;
  break;
  }

  Hope that makes sense.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1366622/+subscriptions